Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky TestDataClients #2558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky TestDataClients #2558

wants to merge 1 commit into from

Conversation

AlexanderYastrebov
Copy link
Member

  • simplify setup boilerplate by using test t.TempDir()
  • remove unrelated options and unused code
  • increase startup wait interval

Fixes #2556

@AlexanderYastrebov
Fix flaky TestDataClients
d5a446f 
* simplify setup boilerplate by using test t.TempDir()
* remove unrelated options and unused code
* increase startup wait interval

Fixes #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov mentioned this pull request Aug 31, 2023
Merged
@szuecs
Copy link
Member

szuecs commented Aug 31, 2023

Please add tests that cover the functionality that was added there. Maybe the test name was a bit miss leading.

@AlexanderYastrebov
Copy link
Member Author

#2557 and #2386 flaked during build

@AlexanderYastrebov
Copy link
Member Author

The flakes are not going anywhere and this test has negative overall value.
I propose we merge this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky TestDataClients
2 participants
@AlexanderYastrebov @szuecs